Hey there! You should be pleased with yourself, this was not an easy angle to pull off. Well done for challenging yourself.

As you wanted some crit from me, here it comes! ^^

The colours you chose for your shading are pretty grey/unsaturated. Whilst there are advanced techniques out there that do call for greys in the shadows, you're not quite capable of doing that just yet. For now, go for more saturated colours.

The contrast is fine, but you're not being bold enough with block shadows. At the moment, every element of the image looks gently lit. But given the spark in the middle, there should be far more extreme/large shadows being cast everywhere.

The hair is very muddily shaded, the strokes are blunt and messy. Make the shadows sharper, longer and smoother.

Hmm, sort out your light sources - is she supposed to be backlit (hence the plain white background) then with highlights/shadows from the red sparK in front? Then always, always keep that in mind as you shade. Her arms should have that sort of shading, the highlight on her hair is misplaced/random, the wings are very indistinct - need more contrast there.

The biggest thing - clean up your base layer, I can see lots of little white bits where you haven't coloured in-between or under the lineart properly! This is a basic, basic skill!

Okay? Sorry if I sound harsh, hun! I just see a lot of potential and if you just fixed those things, this could look really good. ^^

--
My website: [link]
Sweatdrop Studios: [link]

not harsh at all its just what i needed *cracks knuckles* im working on a new piece that needs to be coloured,
the hair was a bitch to do simply cause i had no idea how to do it lol so im useing trial and error technique
i didn't really think about the back light thingy, by the end of it when it came to the bg i though a simple dulled yellow would look good enough,
base layer wise ^__^'''' i am a bit lazy wit the clean up i think i might do digital inking as well see what looks best,

thanks for the great crit harsher the better thus i can work harder to improve...

btw you said it wasn't an easy angle to pull off, but didn't say wheather i did or not lol my proportioning annoys me to no end i am always paranoid about it .

--
I've never felt so accepted in all my life. These people look deep within my soul and assign me a number based on the order in which I joined....

it's true Deviant art stamps every one with a number!!! mines # 7941453

Your angle/proportions aren't too bad actually - there are a few things I would do differently, but a lot of that is down to style and finish.

You don't need to ink digitally to get a clean background! You just need to make sure your colours go well into your lines, on a seperate layer. Hardly any of my stuff is digitally inked.

--
My website: [link]
Sweatdrop Studios: [link]

all the white bits are on the inked layer , i just deleat all the white on the layer and colour underneath, an photo shopping em out is hard and the lines them selves seem to have a feathered grey edge then i would have to either turn the contrast on the scan to make the lines dead black which then the side effect is the lines look really bad or i could erase all the grey edges but that would take days to get it perfect , lord i wish i had full version of PS then i can just click that little button that selects all of the white on a layer....guh rambling again

--
I've never felt so accepted in all my life. These people look deep within my soul and assign me a number based on the order in which I joined....

it's true Deviant art stamps every one with a number!!! mines # 7941453

I don't understand your problem then. All you need to do is make sure your base underneath thorough goes under the lines.

Have you tried setting your lineart layer to Multiply? Effectively, it adds any values underneath to the layer - so it turns all the white transparent.

Or, set the colour mode to RGB, then open up the channels window. Click the dotted circle icon, that selects all the white on the layer. Go back to the layer menu, duplicate your current layer (if your lineart is currently your background), then press delete. This gets rid of all your white in one fell swoop, still leaving the feathered edge. Then lock the transparency of the layer and go over with a large pencil in black to darken the lines.

If your lineart is anti-aliased, then you need to make your selections of the areas you want to colour and increase the selections by 2-3 pixels before filling. THen correct any small pixels left.

If the lineart is pure black & white (my preferred option, so long as you work at 600dpi or above), you can fill very easily, and just correct the small bits here and there afterwards.

Whatever it is, you need to spend time flatting your base colours properly. Depending on the style I use, I sometimes literally paint the base colour underneath by hand (going well over the edges of my lineart) and then erase by hand the bits I don't want.

--
My website: [link]
Sweatdrop Studios: [link]

heh i have only got elements...so alot of those features are unavailiable to me, all i usualy do is use the magic wand tool, you obviously know loads about photoshop, im gonna get a copy soon so this advice is most valuable ^_^ thanks.

--
I've never felt so accepted in all my life. These people look deep within my soul and assign me a number based on the order in which I joined....

it's true Deviant art stamps every one with a number!!! mines # 7941453